Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check query object before $eq in update #12

Open
wants to merge 7 commits into
base: default
Choose a base branch
from

Conversation

cayasso
Copy link

@cayasso cayasso commented Feb 11, 2023

This fails without the first commit fix:

await db.update({ id: '1' }, { $inc: { seq: 1 } })

@cayasso cayasso changed the title Check query object before checking for $eq on update Check query object before $eq in update Feb 11, 2023
@cayasso
Copy link
Author

cayasso commented Feb 11, 2023

Hey, as you can see most of the changes added are small changes, the only important change that can be a breaking change is the BSON upgrade which now exports ObjectId instead of ObjectID.
Thank you for this module!

@RangerMauve
Copy link
Owner

Are the extra changes with the sub-encoder and updated bson module strictly necessary? I notice there is also an empty watch method that got added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants