Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Gnome 46 (beta) #231

Closed
ydaveluy opened this issue Mar 6, 2024 · 27 comments
Closed

Incompatibility with Gnome 46 (beta) #231

ydaveluy opened this issue Mar 6, 2024 · 27 comments

Comments

@ydaveluy
Copy link

ydaveluy commented Mar 6, 2024

Hello,

I tested this extension on Gnome 46 (beta) and it raises a TypeError: this.checkingMenuItem.actor.add_actor is not a function
I think that it comes from:

this.checkingMenuItem.actor.add_actor( checkingLabel );

@RaphaelRochet
Copy link
Owner

I can't believe they manage to break extensions on each and every release.
Like always, will test and (hopefully) fix when it will hit Arch's repos. Any ideas when the release is planned ?

@ydaveluy
Copy link
Author

ydaveluy commented Mar 6, 2024

It should be out on 20 March

@Kerrung
Copy link

Kerrung commented Mar 7, 2024

I can't believe they manage to break extensions on each and every release. Like always, will test and (hopefully) fix when it will hit Arch's repos. Any ideas when the release is planned ?

@RaphaelRochet You don't need to wait for GNOME 46 to appear in the Arch Linux stable repositories. Just install GNOME OS Nightly in a virtual machine and test it there.
https://os.gnome.org/

@RaphaelRochet
Copy link
Owner

@RaphaelRochet You don't need to wait for GNOME 46 to appear in the Arch Linux stable repositories. Just install GNOME OS Nightly in a virtual machine and test it there.

Yep I don"t have t. I want to.

@RaphaelRochet
Copy link
Owner

Looks like I can reproduce with gnome-shell beta from gnome-unstable repo. Will see if this is an easy fix.

@RaphaelRochet
Copy link
Owner

Fixed this one, but now blocking on MessageTray.SystemNotificationSource change 😫

@RaphaelRochet
Copy link
Owner

Ok, done too. Looks promisin :) Only a little bug left !

RaphaelRochet added a commit that referenced this issue Mar 8, 2024
@RaphaelRochet
Copy link
Owner

Ready for testing (branch Gnome46). Let's hop I caught all bugs. Tell me :)

@ydaveluy
Copy link
Author

ydaveluy commented Mar 9, 2024

Yes everything seems fixed, no issue on my side after few updates

@Kerrung
Copy link

Kerrung commented Mar 9, 2024

562d7c9
It doesn't work for me on GNOME 46 from [gnome-unstable].
Screenshot from 2024-03-09 21-31-35

@RaphaelRochet
Copy link
Owner

Ok, disable the manual ordering thin in the options, should work.

@Kerrung
Copy link

Kerrung commented Mar 9, 2024

Ok, disable the manual ordering thin in the options, should work.

I didn't realise what exactly I should disable. Can you please send me a screenshot of this particular setting or at least tell me its exact name? Or maybe it would be better to make your extension work with any enabled settings as it was before?

@RaphaelRochet
Copy link
Owner

It's the option that allow you to set indicator position. Of course I will have to fix this bug. I may remove that feature altogether if needed.

@Kerrung
Copy link

Kerrung commented Mar 9, 2024

It's the option that allow you to set indicator position. Of course I will have to fix this bug. I may remove that feature altogether if needed.

This feature is very much needed to use. I would like to keep it working, please.

@RaphaelRochet
Copy link
Owner

That was an easy fix. But I found another bug on notifications (related to new notification management in 46). Working on it.

@RaphaelRochet
Copy link
Owner

RaphaelRochet commented Mar 11, 2024

A few fixes later all seems to work fine. More testing may be a good thing if you don't mind.
( ea2de9e, dc78270 )

@grg3
Copy link

grg3 commented Mar 24, 2024

46 just hit Arch!
Thankfully, this extension is still working even though it reports an error:
Error: Extension point conflict: there is already a status indicator for role ArchUpdateIndicator

@RaphaelRochet
Copy link
Owner

I can't reproduce this error. Do you have any more info ?

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

I've got a issue here

  • no numbers next to the icon
  • Can't access the update details at all

I've got for example six pending updates but if I click on it nothing
image

@RaphaelRochet
Copy link
Owner

I can't reproduce this either. That's annoying. Another extension messing with indicators maybe ?

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

Can't say... It was working properly with the same extensions on.
I'll investigate.

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

The AUR package is broken too

@RaphaelRochet
Copy link
Owner

Flag it, can't do much about it. Hope the maintainer will update it quickly.

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

Got it...

That must be off otherwise the issue occurs

image

@RaphaelRochet
Copy link
Owner

Ok. I could reproduce this with an error "JS ERROR: TypeError: this.menuExpander.menu.box.add is not a function".
Will fix that, should be an easy fix.

@RaphaelRochet
Copy link
Owner

Should be fixed in Master branch ;)
I caught another error in the meanwhile 😁

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

Should be fixed in Master branch ;) I caught another error in the meanwhile 😁

Nice!

I'll wait for the extension to be pushed on the site

slaclau pushed a commit to slaclau/arch-update-security-news that referenced this issue Mar 24, 2024
slaclau pushed a commit to slaclau/arch-update-security-news that referenced this issue Mar 24, 2024
purejava pushed a commit to purejava/fedora-update that referenced this issue Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants