Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds activityResult to improve promise usability on Android #31

Merged
merged 6 commits into from
May 3, 2023

Conversation

setoba1192
Copy link
Contributor

Adds usability to then promise in the method NativeSettings.open

Platform:

Android


testMethod = () => {
    const options = {
      optionAndroid: AndroidSettings.ApplicationDetails,
      optionIOS: IOSSettings.App,
    };
    /**
     * Current Behavior: Then promise execute immediately
     * New Behavior: Then promise wait to user gets back to screen
     */
    NativeSettings.open(options).then((data) => {
      this.presentAlert('then execution', JSON.stringify(data), '');
    });
  };
video5044381772813435674.mp4

@RaphaelWoude
Copy link
Owner

Thank you for your contribution. I will review & test your PR in the next couple days.

@RaphaelWoude RaphaelWoude self-requested a review May 3, 2023 08:38
Copy link
Owner

@RaphaelWoude RaphaelWoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RaphaelWoude RaphaelWoude merged commit f7327eb into RaphaelWoude:main May 3, 2023
@RaphaelWoude
Copy link
Owner

This functionality will be available with the capacitor 5 build that is coming very soon. See #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants