Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrawContext.enableScissor() does not work for some draw calls #161

Closed
SmajloSlovakian opened this issue Jan 5, 2024 · 0 comments
Closed
Labels
bug Something isn't working confirmed This issue has been reproduced and confirmed

Comments

@SmajloSlovakian
Copy link

this introduces a visual bug with my mod called Smooth Scroll in ingame chat
where the scissor happens (line 60): https://github.com/SmajloSlovakian/Minecraft-Smooth-Scrolling/blob/main/src/main/java/smsk/smoothscroll/mixin/ChatHudMixin.java
the mixin is at the start of ChatHud.render()

with this mod, scissor is not applying only to the drawtext and drawrectangle (and related) methods - i use it for some other draw methods and it works as expected

Videos:

without IF:
https://github.com/RaphiMC/ImmediatelyFast/assets/16209307/d33ce139-5719-4b94-ae8e-4f135fbb94dc
with IF:
https://github.com/RaphiMC/ImmediatelyFast/assets/16209307/87b90798-d4cf-46f6-994b-2f7d5f5b5be8

@RaphiMC RaphiMC added bug Something isn't working not-confirmed This issue has not been reproduced by anyone yet labels Jan 5, 2024
@RaphiMC RaphiMC added confirmed This issue has been reproduced and confirmed and removed not-confirmed This issue has not been reproduced by anyone yet labels May 1, 2024
@RaphiMC RaphiMC closed this as completed in cf3fbab May 1, 2024
RaphiMC added a commit that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed This issue has been reproduced and confirmed
Projects
None yet
Development

No branches or pull requests

2 participants