Converted SAPI5 driver and espeak driver to be compatible with 2.7 and 3.4 #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying and get a mac so I can convert that driver as well but at the moment I do not have access to one. In the meantime I have converted the other two drivers as well as the main libraries. I used python six for most of the compatibility changes. I have run the unit tests on:
Windows 64 bit 2.7
Windows 64 bit 3.4
Linux 64 bit 2.7
Linux 64 bit 3.4
I know that some of the changes I have made are not compatible with 2.5 (and possibly 2.6) but I don't know if the code was already compatible with those earlier versions or not. My assumption was that it was only compatible with 2.7.
Feel free to suggest changes or a different way of doing things, I should have some time to work on this over the next few months as I will be using this library in my next project.