Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failing on mac os #142

Merged
merged 8 commits into from Jun 12, 2023
Merged

Fix test failing on mac os #142

merged 8 commits into from Jun 12, 2023

Conversation

areedv
Copy link
Contributor

@areedv areedv commented Jun 9, 2023

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_rapbase.html.

Please correct before 2023-06-12 to safely retain your package on CRAN

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (556ed69) 96.94% compared to head (92319f4) 96.94%.

❗ Current head 92319f4 differs from pull request most recent head bdc12a5. Consider uploading reports for the commit bdc12a5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          16       16           
  Lines        1765     1765           
=======================================
  Hits         1711     1711           
  Misses         54       54           
Impacted Files Coverage Δ
R/log.R 97.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@areedv
Copy link
Contributor Author

areedv commented Jun 9, 2023

Jeg har ikke klart å reprodusere feil som Cran rapporterer for macOS, men jeg har en antagelse at den kan skyldes api-kall mot github. Disse er nå pakket inn og skjer i mot lokale filer (mock directory). Satser på å få ut ny versjon på mandag 12. juni 2023 👻

@areedv areedv requested a review from arnfinn June 9, 2023 13:40
@areedv areedv marked this pull request as ready for review June 9, 2023 13:40
arnfinn
arnfinn previously approved these changes Jun 12, 2023
@areedv areedv merged commit 4f52ea2 into master Jun 12, 2023
9 checks passed
@areedv areedv deleted the mac-retest branch June 12, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants