Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gtable support #198

Merged
merged 1 commit into from Jul 20, 2015
Merged

Conversation

RomanTsegelskyi
Copy link
Contributor

Support for gtable S3 class from gtable package

@@ -1,4 +1,4 @@
% Generated by roxygen2 (4.1.1): do not edit by hand
% Generated by roxygen2 (4.1.0): do not edit by hand
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update roxygen on your computer :) 4.1.1 is out since ~April.

@daroczig
Copy link
Member

Although it indeed seems to be nice to have, but can you please add/mention a use-case where pander support for gtable is useful? I'm honestly interested in this (BTW looks good for merge).

@RomanTsegelskyi
Copy link
Contributor Author

Honestly, that's a very good question indeed. My thought was that it might be used in knitr for additional explanation, but as I think about it more, it might be a bit redundant. No merge then?

@daroczig
Copy link
Member

If it's already done, we should merge :)

RomanTsegelskyi added a commit that referenced this pull request Jul 20, 2015
@RomanTsegelskyi RomanTsegelskyi merged commit de657fe into Rapporter:master Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants