Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Activity.created_at #2446

Closed
wants to merge 2 commits into from
Closed

Add Activity.created_at #2446

wants to merge 2 commits into from

Conversation

NCPlayz
Copy link
Contributor

@NCPlayz NCPlayz commented Nov 23, 2019

Summary

This implements Activity#created_at, which is present for all types of activities.

Reviews are welcome.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Rapptz
Rapptz requested changes Nov 26, 2019
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than doing all this repetition it's better to just implement this in _ActivityTag which all activities implement.

@Rapptz Rapptz added the merged Tag to mark pull requests as rebased or merged label Dec 4, 2019
@Rapptz Rapptz closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rapptz Rapptz Rapptz approved these changes

Assignees
No one assigned
Labels
merged Tag to mark pull requests as rebased or merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NCPlayz @Rapptz