Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sticker support #5946

Merged
merged 25 commits into from
Nov 23, 2020
Merged

Add sticker support #5946

merged 25 commits into from
Nov 23, 2020

Conversation

Zomatree
Copy link
Contributor

Summary

Adds sticker support to discord.py, this doesn't add any new endpoints just the stuff on the message class.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Gobot1234
Gobot1234 reviewed Oct 18, 2020
View reviewed changes
discord/message.py Outdated Show resolved Hide resolved
Gobot1234
Gobot1234 reviewed Oct 18, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
RocketRace
RocketRace reviewed Oct 18, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
numbermaniac
numbermaniac reviewed Oct 18, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
numbermaniac
numbermaniac reviewed Oct 18, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
numbermaniac
numbermaniac reviewed Oct 18, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
numbermaniac
numbermaniac reviewed Oct 18, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
Zomatree and others added 4 commits October 18, 2020 03:42
@Zomatree @numbermaniac
grammer
8198688 
Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
@Zomatree @numbermaniac
grammer
44c2e52 
Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
@Zomatree @numbermaniac
grammer
a8c9e6c 
Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
@Zomatree @numbermaniac
grammer
9245b0e 
Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
numbermaniac
numbermaniac reviewed Oct 21, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
@Zomatree @numbermaniac
Update discord/sticker.py
0bf4310 
Co-authored-by: numbermaniac <5206120+numbermaniac@users.noreply.github.com>
boyscoutwyatt
boyscoutwyatt approved these changes Nov 4, 2020
View reviewed changes
Copy link

@boyscoutwyatt boyscoutwyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good

Rapptz
Rapptz requested changes Nov 22, 2020
View reviewed changes
discord/sticker.py Outdated Show resolved Hide resolved
discord/sticker.py Show resolved Hide resolved
discord/message.py Outdated Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
docs/api.rst Outdated Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
discord/sticker.py Show resolved Hide resolved
discord/sticker.py Outdated Show resolved Hide resolved
@Rapptz Rapptz added this to the v1.6 milestone Nov 22, 2020
Zomatree and others added 8 commits November 22, 2020 23:59
@Zomatree @Rapptz
Update discord/sticker.py
5a194c9 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/message.py
20835d0 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/sticker.py
7f26c62 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/sticker.py
63b727d 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/sticker.py
8ef4ef1 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/sticker.py
af504b2 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/sticker.py
4d453c2 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
@Zomatree @Rapptz
Update discord/sticker.py
01f4ed6 
Co-authored-by: Danny <Rapptz@users.noreply.github.com>
Rapptz
Rapptz approved these changes Nov 23, 2020
View reviewed changes
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I'm unsure on the stability of the tags attribute and whether there's any weird gotchas with it when it's split by comma.

@Rapptz Rapptz merged commit 344cb96 into Rapptz:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@numbermaniac numbermaniac numbermaniac left review comments

@RocketRace RocketRace RocketRace left review comments

@parafoxia parafoxia parafoxia left review comments

@Gobot1234 Gobot1234 Gobot1234 left review comments

@Rapptz Rapptz Rapptz approved these changes

@boyscoutwyatt boyscoutwyatt boyscoutwyatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@Zomatree @Rapptz @numbermaniac @RocketRace @parafoxia @Gobot1234 @boyscoutwyatt