Change Spotify.__eq__ #2115
Closed
Change Spotify.__eq__ #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it check both _session_id and _sync_id
6 tasks
| @@ -497,7 +497,7 @@ def name(self): | |||
| return 'Spotify' | |||
|
|
|||
| def __eq__(self, other): | |||
| return isinstance(other, Spotify) and other._session_id == self._session_id | |||
| return isinstance(other, Spotify) and other._session_id == self._session_id and other._sync_id == self._sync_id | |||
There was a problem hiding this comment.
This line might be too long.
As I suggest in #2117, I think checking other.start == self.start is necessary as well.
|
Superseded by #2117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it check both _session_id and _sync_id
Summary
Changes Spotify.eq to make it more accurate.
Checklist