Add new AuditLogAction types #2427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apple502j
suggested changes
Nov 20, 2019
| message_id = int(self.extra['message_id']) | ||
| elems = { | ||
| 'channel': self.guild.get_channel(channel_id) or Object(id=channel_id), | ||
| 'message_id': message_id |
There was a problem hiding this comment.
Possibly self.guild._state._get_message()?
There was a problem hiding this comment.
Don't think so.
Audit logs aren't sent via WS events so there's no way to know when exactly to make a cache of the message.
apple502j
reviewed
Nov 20, 2019
modelmat
reviewed
Nov 20, 2019
modelmat
reviewed
Nov 20, 2019
Co-Authored-By: Modelmat <Modelmat@users.noreply.github.com>
Co-Authored-By: Modelmat <Modelmat@users.noreply.github.com>
|
It's not in description of this PR but it resolves #2426 |
Guy293
reviewed
Dec 26, 2019
discord/enums.py
Outdated
| @@ -341,6 +353,9 @@ def category(self): | |||
| AuditLogAction.emoji_update: AuditLogActionCategory.update, | |||
| AuditLogAction.emoji_delete: AuditLogActionCategory.delete, | |||
| AuditLogAction.message_delete: AuditLogActionCategory.delete, | |||
| AuditLogAction.integration_create: AuditLogActionCategory.create, | |||
| AuditLogAction.integration_update: AuditLogActionCategoty.update, | |||
There was a problem hiding this comment.
You have a mistype here,
AuditLogActionCategoty
Instead of
AuditLogActionCategory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new audit log entry types specified in discord/discord-api-docs#1191
Also fixes an issue with unknown audit log types with extra data causing an exception.
Checklist