Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands] Added optional arguments to load_extension #5839

Closed
wants to merge 1 commit into from
Closed

[commands] Added optional arguments to load_extension #5839

wants to merge 1 commit into from

Conversation

FrostByte266
Copy link

Summary

I have added the ability to pass extra positional and keyword arguments to an extension's setup method to provide a nice way to share data with an extension and the main bot code. I have tested this and code that doesn't pass extra arguments works the same as before, and passing positional and keyword arguments to the setup function also works.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented Sep 21, 2020

This isn't really a design space I want to explore like this. Indiscriminately passing parameters like this tends to block the load_extension from being changed (e.g. if I wanted to pass a package path to importlib in the future). There is another method being explored to allow to pass configuration in an extension but that'll be explored once the library moves on to Python 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants