Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands] Add support for type statement and NewType #9815

Merged
merged 3 commits into from
May 5, 2024

Conversation

bijij
Copy link
Contributor

@bijij bijij commented May 2, 2024

Summary

This PR adds support for typing.NewType and type statement type aliases.
Closes #9813

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz
Copy link
Owner

Rapptz commented May 5, 2024

Might be worth doing this for app_commands as well?

@bijij
Copy link
Contributor Author

bijij commented May 5, 2024

At least doing a quick test this seems to work out of the box since app_commands also relies on the code in utils, unless I'm missing something.

@Rapptz
Copy link
Owner

Rapptz commented May 5, 2024

Oh my mistake. I noticed this is actually within utils. For some reason on first read I thought this was under commands.py.

@Rapptz Rapptz merged commit 9fab99a into Rapptz:master May 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for 3.12 type aliases
2 participants