Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add freebsd support #302

Merged
merged 2 commits into from Jul 17, 2023
Merged

feat: add freebsd support #302

merged 2 commits into from Jul 17, 2023

Conversation

0vf
Copy link
Contributor

@0vf 0vf commented Jul 16, 2023

This PR will add full FreeBSD support to Rare
image
image

Copy link

@TeknosQuet TeknosQuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@loathingKernel
Copy link
Contributor

loathingKernel commented Jul 16, 2023

Thank you for your contribution!

A few general questions:

  • Can we safely assume that FreeBSD == Linux in all possible use-cases in Rare?
  • Have you checked if Legendary detects FreeBSD accordingly, if not, have you made a PR there or is it something that should be done?

One thing missing AFAICS is to include the required modifications in setup.py, requirements.txt and other relevant dist files completeness.

@0vf
Copy link
Contributor Author

0vf commented Jul 16, 2023

Legendary already works in FreeBSD OOTB, and in most cases, yes you can assume that FreeBSD == Linux (you can safely assume that freebsd == linux in the rare project continuing from now, as they both share the same window systems, desktop environments, standards, etc etc. the difference only really matters in compiled projects (eg. C, C++, rust), as freebsd is more similar to macos in that regard)

And also, thank you! I'll work more on this PR

@0vf
Copy link
Contributor Author

0vf commented Jul 16, 2023

Another small issue is that the pip package pyqt5 won't build on FreeBSD normally, so the use of the py39-qt5 package will be required

@0vf
Copy link
Contributor Author

0vf commented Jul 16, 2023

image
i think the PR is now ready, let me know if i've missed anything!

@loathingKernel
Copy link
Contributor

Looks fine to me 👍

@Dummerle
Copy link
Collaborator

Thank you!

@Dummerle Dummerle merged commit 74802eb into RareDevs:main Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants