A small number of fixes that could be made into a minor release #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loathingKernel
force-pushed
the
fixups
branch
from
57a8bbe
to
0d6cb24
Compare
loathingKernel
force-pushed
the
fixups
branch
3 times, most recently
from
da4d062
to
b6f3a5f
Compare
…n game Move validation after the DLCs have been added so the can be uninstalled too if the game can't be found.
The order was determined by the order of the container dictionary entries. Re-order them before returning the list by their index in the container widget. Fixes RareDevs#304
Truncate the widget's text down to the command only without the arguments. Show the full command with the arguments in the tooltip instead. Update some text.
Internally this works by removing the old wrapper and adding a new wrapper int the same index.
Removed some superfluous variables that were already exposed through RareGame and moved around some block to correct initialization errors after moving to instance attributes
Add icons to the DLC install/uninstall buttons
to populate the combobox
RareCore was connecting RareGames to the same signals multiple times when the library was refreshed.
loathingKernel
force-pushed
the
fixups
branch
from
b6f3a5f
to
d6809c2
Compare
Thanks, UwU
* Load and populate Ubisoft information when the page is shown instead of startup. * List all Ubisoft games, and differentiate based on whether they been redeemed.
This widget is currently unused and could be deleted
Previously a lot of things would start running concurrently at startup as we were setting up the UI. This removes a considerable amount of perceived delay. Note: there are better ways to make sure forms are populated when they are viewed, such as each widget's `showEvent()`
After the PathEdit change that stopped it from emitting the textChanged signal when instatiated, the available space calculation wouldn't take place, so do it when the dialog becomes visible.
Instead of loading images in the showEvent of the MainWindow, load them in the showEvent of each widget. It seems to reduce the startup stuttering this way. With some more work we can only load the images for the widgets that are currently visible and reduce the stutter even more. At the same time, reduce the number of concurrent downloads in the image manager and add a timeout so we won't halt. The exception from the timeout is just logged at this point, and the download is not requeued.
Spontaneous are events external to the application such as the window manager showing or hiding the application. We don't want to update on those.
* Don't hide irrelevant elements in Windows, disable them and use them as information * Create the `Manifests` folder in ProgramData if its parent exists.
Revert this commit once the new version of Legendary (`>0.20.33`) is released
loathingKernel
force-pushed
the
fixups
branch
from
d359b66
to
7979563
Compare
loathingKernel
force-pushed
the
fixups
branch
from
512aa65
to
d45d307
Compare
|
If there are no objections I will be merging this later today. Legendary's developer said they will be releasing a new version soon, which will probably break our |
Revert this commit once the new version of Legendary (`>0.20.33`) is released
These properties or methods were moved to RareGameBase * `version`: For RareEosOverlay and maybe RareGameSlim * `is_origin`: For RareGameSlim * `install_path`: A partial Origin-unaware version * `is_mac/is_win32`: For completeness New methods * `is_overlay`: For the download manager Signed-off-by: loathingKernel <142770+loathingKernel@users.noreply.github.com>
loathingKernel
force-pushed
the
fixups
branch
from
ddd1030
to
842bd27
Compare
|
I tested it through Wine today, and it works there too. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Features
Modifybutton in Game Information to allow installing/uninstalling selectable downloads after the initial installation.compilerhud option in DXVK.Bug fixes
0.20.33