Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dot syntax when checking if a session has a value #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamtomat
Copy link
Member

Given:

session()->put([
    'foo' => [
        'bar' => 123,
    ],
]);

I expected session()->has('foo.bar') to return true, however it returns false because it currently doesn't support dot syntax.

This MR is to allow dot syntax for the has method on the session store object.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.698% when pulling 7f586de on allow-dot-syntax-for-session-has into d877406 on master.

@joelambert joelambert force-pushed the allow-dot-syntax-for-session-has branch from 7f586de to c4c7db8 Compare October 1, 2021 16:10
@joelambert
Copy link
Member

@adamtomat we need to add a test for this behaviour before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants