Add PHP 8 support #27
Conversation
|
Failing tests due to a PHP 8 issue with Timber. Code has been patched but not yet released, see: timber/timber#2450 |
joelambert
force-pushed
the
add-php8-support
branch
from
8e0affa
to
d3aeb8b
Compare
PHPUnit v9 doesn't like to run standalone if there's a copy also installed via composer
It's not a very stable dependency and doesn't add enough value for the headache it causes.
v1.6.10 onwards has support for PHP 8.1 syntax but this is causing issues with some of the other testing libraries we have which haven't yet updated their support. Holding back until Mockery and Brainmonkey have better 8.1 support.
|
From what I can see it has been merged 😄 🙏 |
|
Any new news regarding the support for PHP 8 @adamtomat |
8.1 will need us to resolve a few other issues in 3rd party packages first.
|
I've rolled back the commit to add PHP 8.1 as a test environment. There are a few other issues in 3rd party packages that we'll need to resolve before this becomes possible. |
|
Hi! Great to see this, what is currently outstanding for support of at least PHP 8.0? |
|
Hi, what is left to at least support PHP 8? |
|
@joelambert would love to see this merged. Is there anything outstanding? Happy to help where I can. |
|
@trsteel88 we just need to test this on some existing sites to make sure there are no issues. If you're able to do any testing and let us know if it's good / of any bugs that would be 👍 We plan on doing some thorough testing in the next couple weeks too |
|
I would be happy to run it for testing, I didn't know what was outstanding or not |
rareloop/routerto include the fix