Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skills #44

Merged
merged 15 commits into from
Sep 16, 2021
Merged

Feature/skills #44

merged 15 commits into from
Sep 16, 2021

Conversation

TBouder
Copy link
Contributor

@TBouder TBouder commented Sep 14, 2021

What it does ✨

Add the SkillBook and the Skills to Rarity Extended.
Skills are following the logic of this contract explained on this medium post. Design was made by our well know designer and we are re-working the design system based on this PR !

You can now:

  • See the skills of your adventurers
  • Set some skills if you have available points
  • Get the details of the skills
  • Work with reponsive design

Capture d’écran 2021-09-16 à 12 19 48
Capture d’écran 2021-09-16 à 12 20 06
Capture d’écran 2021-09-16 à 12 21 12
Capture d’écran 2021-09-16 à 12 19 39

How to test ✅

You should be able to set the skills for your adventurer without issue.

@TBouder TBouder added the enhancement New feature or request label Sep 14, 2021
@TBouder TBouder added this to In Progress in Rarity Extended via automation Sep 14, 2021
@vercel
Copy link

vercel bot commented Sep 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbouder/rarity/HELd6QeMJPd1Sx1jugD34bXL5nsC
✅ Preview: https://rarity-git-feature-skills-tbouder.vercel.app

@Ceazor
Copy link
Collaborator

Ceazor commented Sep 16, 2021

Add.. "Your Current Attributes" in the circle

image

@Ceazor
Copy link
Collaborator

Ceazor commented Sep 16, 2021

Change Adventures to "Quests" or "Dungeons"

So players don't get confused between daily XP "adventures"
image

@TBouder TBouder marked this pull request as ready for review September 16, 2021 10:21
@TBouder TBouder moved this from In Progress to To Review in Rarity Extended Sep 16, 2021
@saltyfacu
Copy link
Collaborator

saltyfacu commented Sep 16, 2021

When I go into SKILLS, I select the skill and click "LEARN", MM opens, I confirm, nothing happens.
Why? I need to change level 0 to level 1.
LEARN button shouldn't be enabled if it's not possible to actually LEARN anything

When I assign every point I have, back arrows disappear without clicking LEARN.
This only happens when I assign points to a skill that I've already learned.

  • I learn CONCENTRATION, so I have it with level 1
  • I go to my skills and increase it's level until 5, I cannot decrease it any more

I learned 2 skills and magically got 25.5 points
Should I get half a point for some reason? How did I get those 25 points?

Check the screenshot

Screenshot 2021-09-16 at 12 43 28

Inventory is not according to figma

  • These two buttons are very different. We should use the "go to the quest office" button.
  • It has a line separating the tab title from the body when Skills doesn't have it.

Screenshot 2021-09-16 at 12 47 14

@saltyfacu
Copy link
Collaborator

Nice to have: when I have only 1 point left, it'd be nice to remove the arrow from skills that cost 2 points, like what we do when all points are spent.

Copy link
Collaborator

@saltyfacu saltyfacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job! I love it. Just a "nice to have". Ship eet

@TBouder TBouder merged commit 20ad023 into main Sep 16, 2021
Rarity Extended automation moved this from To Review to Done Sep 16, 2021
@TBouder TBouder deleted the feature/skills branch September 18, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants