-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/skills #44
Feature/skills #44
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tbouder/rarity/HELd6QeMJPd1Sx1jugD34bXL5nsC |
When I go into SKILLS, I select the skill and click "LEARN", MM opens, I confirm, nothing happens. When I assign every point I have, back arrows disappear without clicking LEARN.
I learned 2 skills and magically got 25.5 points Check the screenshot Inventory is not according to figma
|
Nice to have: when I have only 1 point left, it'd be nice to remove the arrow from skills that cost 2 points, like what we do when all points are spent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome job! I love it. Just a "nice to have". Ship eet
What it does ✨
Add the SkillBook and the Skills to Rarity Extended.
Skills are following the logic of this contract explained on this medium post. Design was made by our well know designer and we are re-working the design system based on this PR !
You can now:
How to test ✅
You should be able to set the skills for your adventurer without issue.