Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/crafting #83

Merged
merged 45 commits into from
Sep 28, 2021
Merged

Feature/crafting #83

merged 45 commits into from
Sep 28, 2021

Conversation

Majorfi
Copy link
Contributor

@Majorfi Majorfi commented Sep 26, 2021

What it does ✨

Add the crafting to the UI !

This is a big PR with a lot of stuff.
There is some part of the new UI, it's dependant of #74 and #73.
There is a new tab (Inventory) which will be used to display all the items for a specific address (player address). The items crafted are not linked to a specific adventurer, but to the address, unlike the crafting materials (rat skin), the gold, or the artifacts from The Forest.
The crafting system is based on the Current Adventurer that can be changed on the top right menu.
The crafting success is based on the Intelligence, the Craft skill level and a random dice. You can use 10 rat skin to increase your success chance. Each item has a specific difficulty based on some caracteristics.
I tried to handle all the situations, but I may have missed some of them !

Capture d’écran 2021-09-26 à 14 18 57

Capture d’écran 2021-09-26 à 14 20 09

Capture d’écran 2021-09-26 à 13 58 38

Capture d’écran 2021-09-26 à 13 59 28

Capture d’écran 2021-09-26 à 14 24 33

Capture d’écran 2021-09-26 à 13 59 38

Capture d’écran 2021-09-26 à 14 26 59

Capture d’écran 2021-09-26 à 14 00 10

Capture d’écran 2021-09-26 à 14 00 19

Capture d’écran 2021-09-26 à 14 00 25

Capture d’écran 2021-09-26 à 14 00 37

Capture d’écran 2021-09-26 à 14 00 42

Capture d’écran 2021-09-26 à 14 01 26

Capture d’écran 2021-09-26 à 14 18 14

Ceazor and others added 3 commits September 27, 2021 12:04
Changed
* 2 images
* a few things Ceazor says
* some text in an error (The craftmaster to CEAZOR)
typo in my own edits
@saltyfacu
Copy link
Collaborator

  • How can I test the restore artifact from the previous version?
  • I go to the blacksmith, upgrade an artifact, and it takes me to the main screen. I should stay in the Blacksmith
  • Crafted some stuff, a lot of stuff, and it doesn't show in the players inventory, only in the general one

@Majorfi
Copy link
Contributor Author

Majorfi commented Sep 28, 2021

* How can I test the restore artifact from the previous version?

* I go to the blacksmith, upgrade an artifact, and it takes me to the main screen. I should stay in the Blacksmith

* Crafted some stuff, a lot of stuff, and it doesn't show in the players inventory, only in the general one

Thank you for this review !
For the restore artifact, the best way to test it is to have an artifact ... But this code has not been updated since the PR #59, and I think @TheAustrian1998 did a review of that !

Good call for the redirect, I will change that (EDIT : ✅)

Yep, kind of a hell ... The items your adventurer are crafting, with their own specific gold, XP or crafting materials, are not linked to them, but only to the player wallet. There is not adventurerID for the ERC721 created, just an owner, which is the player address. So we cannot link an item to a specific adventurer, unless we re-do this contract to handle that

Copy link
Collaborator

@saltyfacu saltyfacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Majorfi Majorfi merged commit f321abc into main Sep 28, 2021
@Majorfi Majorfi deleted the feature/crafting branch September 28, 2021 16:47
Rarity Extended automation moved this from To Review to Done Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants