Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of days in WporgClient::getPluginDownloads to 730 #2

Closed
engelen opened this issue Nov 24, 2016 · 2 comments
Closed

Limit number of days in WporgClient::getPluginDownloads to 730 #2

engelen opened this issue Nov 24, 2016 · 2 comments
Assignees

Comments

@engelen
Copy link

engelen commented Nov 24, 2016

The WordPress API will use the default limit (180 days) if the limit passed to in the API call exceeds 731. The getPluginDownloads method of WporgClient should probably attend to this by limiting the number of days to 730 and mentioning it in the method's block-documentation.

@Rarst
Copy link
Owner

Rarst commented Nov 24, 2016

Is this documented something (so it can be linked to) or just empirically determined?

@Rarst Rarst self-assigned this Nov 24, 2016
@Rarst Rarst closed this as completed in d4f2def Nov 24, 2016
@engelen
Copy link
Author

engelen commented Nov 24, 2016

It's not documented anywhere as far as I know, but I've determined it empirically with quite some certainty, and the fact that it's 2*365 adds to my suspicion that it is no coincidence :-). Anyway, saw the commit, nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants