Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #208 (min speed = 0) #219

Merged
merged 5 commits into from
Dec 18, 2022
Merged

Fix #208 (min speed = 0) #219

merged 5 commits into from
Dec 18, 2022

Conversation

Raruto
Copy link
Owner

@Raruto Raruto commented Oct 30, 2022

Close: #208 Close: #224 Close: #227


Related to:

TODO: check skipNullZCoords behavior (before / after this edit)

@Raruto
Copy link
Owner Author

Raruto commented Nov 19, 2022

Hi @hupe13,

If you have absolutely nothing to do, let me know what you think of these latest changes.

Surely they also introduce some related bugs due to the presence of NaN in the geojson layer (eg. when you try to display the hotline layer for a gpx file that is missing some altitude values).

BTW I guess this problem was introduced by the _registerDataAttribute during the 2.x refactoring (in trying to handle all the new extensions added in the src/handlers folder).

But anyway this is all my speculation (it's all code that I look at very occasionally..)

Thanks for your patience,
Raruto

@hupe13
Copy link
Contributor

hupe13 commented Dec 1, 2022

min speed seems to be okay.

@Raruto
Copy link
Owner Author

Raruto commented Dec 17, 2022

@hupe13 Related to: #224 (comment), let me know if here we can proceed with the merge (or if other adjustments are needed) and subsequent release of the new version.

@Raruto Raruto changed the title Attempt to fix #208 (min speed = 0) Fix #208 (min speed = 0) Dec 17, 2022
@hupe13
Copy link
Contributor

hupe13 commented Dec 17, 2022

I think so. I have tested it and it seems to be correct.

@Raruto Raruto marked this pull request as ready for review December 18, 2022 10:48
@Raruto Raruto merged commit a1b111e into master Dec 18, 2022
@Raruto Raruto deleted the min-speed-0 branch December 18, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants