Form slot validation for 1st sentence

[ArjaanBuijk]

Forms: slot validation for 1st sentence that triggered the intent:
The helper function Tracker.form_slots_to_validate returned an empty dictionary when there was no active_loop.

As a result, slot-validation was skipped for slots that were filled with entities extracted from the 1st sentence.

The fix is not to check on active_loop.

Fixes #269

Status (please check what you already did):

• made PR ready for code review
• updated the test test_get_extracted_slots_with_no_active_loop
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[CLAassistant]

All committers have signed the CLA.

[wochinge]

Thanks for catching this! I think we need another safe guard then that the slots were actually set by a form execution. We are creating the temporary tracker here , which is then sent to the action server.

One safeguard idea: If the action before the slots is not an ActionExecuted(form_name), then return an empty dict.

[Ghostvv]

I think we don't need the safe guard, because it searches for the past slots that were set before something else happened, if users want to access it, why not?

[wochinge]

then we should change the name of the function (this would also need to be changed in the docs). Up to @ArjaanBuijk imo

[Ghostvv]

+1 to renaming (we anyhow, get rid of form everywhere)

[wochinge]

we anyhow, get rid of form everywhere)

Why? It is a form. No need to rename this because of loop

[Ghostvv]

it can be used everywhere including loop, so it is not only for forms. I'd remove a guard and rename it to smth like last_set_slots

[wochinge]

both options are fine to me (safe guard or renaming and removing safeguard) 👍

[wochinge]

cc @alwx As this renames form_slots_to_validate to slots_to_validate

[Ghostvv]

🚀