Skip to content

Commit

Permalink
Add exceptions for not Semantic Versions
Browse files Browse the repository at this point in the history
  • Loading branch information
tczekajlo committed Oct 16, 2020
1 parent 96b2674 commit 8c7b46f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/rasa-x/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: v2

version: "1.6.7"
version: "1.6.8"
appVersion: "0.30.1"

name: rasa-x
Expand Down
7 changes: 6 additions & 1 deletion charts/rasa-x/templates/rasa-config-files-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,17 @@ data:
username: "{{ .Values.rabbitmq.rabbitmq.username }}"
password: ${RABBITMQ_PASSWORD}
port: {{ default 5672 .Values.rabbitmq.service.port }}
{{ if or (regexMatch ".*(a|rc)[0-9]+" .Values.rasa.tag) (regexMatch "2.*[0-9]+-full" .Values.rasa.tag) -}}
queues:
- ${RABBITMQ_QUEUE}
{{- else -}}
{{ if semverCompare ">= 1.9.0" .Values.rasa.tag -}}
queues:
- ${RABBITMQ_QUEUE}
- ${RABBITMQ_QUEUE}
{{- else -}}
queue: ${RABBITMQ_QUEUE}
{{- end }}
{{- end }}
action_endpoint:
url: "http://{{ include "rasa-x.fullname" . }}-app:{{ template "rasa-x.custom-actions.port" . }}{{ .Values.app.endpoints.actionEndpointUrl }}"
token: ""
Expand Down

1 comment on commit 8c7b46f

@loomsen
Copy link
Contributor

@loomsen loomsen commented on 8c7b46f Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this breaks our CI/CD... We have a commit hash as rasa.tag in development. This breaks here:

Error: template: rasa-x/templates/rasa-x-deployment.yaml:23:33: executing "rasa-x/templates/rasa-x-deployment.yaml" at <include (print $.Template.BasePath "/rasa-config-files-configmap.yaml") .>: error calling include: template: rasa-x/templates/rasa-config-files-configmap.yaml:40:12: executing "rasa-x/templates/rasa-config-files-configmap.yaml" at <semverCompare ">= 1.9.0" .Values.rasa.tag>: error calling semverCompare: Invalid Semantic Version

Please sign in to comment.