Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rasa Pro 3.8.x #352

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Support Rasa Pro 3.8.x #352

merged 5 commits into from
Apr 4, 2024

Conversation

amalsgit
Copy link
Contributor

@amalsgit amalsgit commented Apr 3, 2024

JIRA: https://rasahq.atlassian.net/browse/RST-2598

  • change lock_store value in configmap to concurrent_redis to support Rasa Pro 3.8.0 version
  • This change would make the latest version of the helm chart non-compatible with older version of Rasa Plus. The latest version of Rasa-x helm will only support Rasa Pro 3.8.0

Relevant slack threads:

@amalsgit amalsgit requested review from miraai and l2nguyen April 3, 2024 15:47
@amalsgit amalsgit requested a review from souvikg10 April 4, 2024 07:35
Copy link

@l2nguyen l2nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it the changes on our CSE cluster in GKE using:
rasa-pro:3.8.0
rasa-x:1.4.0

Everything works as expected.

Did we want to change the default image in the values to rasa-pro:3.8.0 image? so:

  • rasa.name at line 151 to europe-west3-docker.pkg.dev/rasa-releases/rasa-pro/rasa-pro
  • rasa.tag at line 153 to 3.8.0

@amalsgit
Copy link
Contributor Author

amalsgit commented Apr 4, 2024

I tested it the changes on our CSE cluster in GKE using: rasa-pro:3.8.0 rasa-x:1.4.0

Everything works as expected.

Did we want to change the default image in the values to rasa-pro:3.8.0 image? so:

  • rasa.name at line 151 to europe-west3-docker.pkg.dev/rasa-releases/rasa-pro/rasa-pro
  • rasa.tag at line 153 to 3.8.0

Thanks, @l2nguyen for testing this. I will make the changes you suggested.

@amalsgit amalsgit merged commit 3cfc5bf into main Apr 4, 2024
3 checks passed
@amalsgit amalsgit deleted the RST-2598-rasa-pro-3-8 branch April 4, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants