Skip to content

Commit

Permalink
Merge pull request #5796 from RasaHQ/clean-up-entities
Browse files Browse the repository at this point in the history
Keep clean_up_entities just for custom entity extractors
  • Loading branch information
tabergma committed May 11, 2020
2 parents 2e1c0ff + dd93c37 commit 507d63c
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 3 deletions.
2 changes: 2 additions & 0 deletions changelog/5755.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove ``clean_up_entities`` from extractors that extract pre-defined entities.
Just keep the clean up method for entity extractors that extract custom entities.
1 change: 0 additions & 1 deletion rasa/nlu/extractors/duckling_http_extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ def process(self, message: Message, **kwargs: Any) -> None:
)

extracted = self.add_extractor_name(extracted)
extracted = self.clean_up_entities(message, extracted)
message.set(ENTITIES, message.get(ENTITIES, []) + extracted, add_to_output=True)

@classmethod
Expand Down
1 change: 0 additions & 1 deletion rasa/nlu/extractors/mitie_entity_extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ def process(self, message: Message, **kwargs: Any) -> None:
mitie_feature_extractor,
)
extracted = self.add_extractor_name(ents)
extracted = self.clean_up_entities(message, extracted)
message.set(ENTITIES, message.get(ENTITIES, []) + extracted, add_to_output=True)

@classmethod
Expand Down
1 change: 0 additions & 1 deletion rasa/nlu/extractors/spacy_entity_extractor.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def process(self, message: Message, **kwargs: Any) -> None:
spacy_nlp = kwargs.get("spacy_nlp", None)
doc = spacy_nlp(message.text)
all_extracted = self.add_extractor_name(self.extract_entities(doc))
all_extracted = self.clean_up_entities(message, all_extracted)
dimensions = self.component_config["dimensions"]
extracted = SpacyEntityExtractor.filter_irrelevant_entities(
all_extracted, dimensions
Expand Down

0 comments on commit 507d63c

Please sign in to comment.