Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort predicted actions on probability score from HTTP API #2973

Closed
therealdeadly opened this issue Feb 9, 2019 · 7 comments
Closed

Sort predicted actions on probability score from HTTP API #2973

therealdeadly opened this issue Feb 9, 2019 · 7 comments
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@therealdeadly
Copy link
Contributor

Rasa Core version: 0.12.4

Python version: 3.6

Operating system (windows, osx, ...): windows

Issue: Currently, the API endpoint :- /conversations/{sender_id}/predict doesn't return the actions in the score array sorted on their score(probabilities) values.
Is it feasible to sort the array in the server.predict(), just like in the training.interactive._request_action_from_user() in consequence removing the need to implement it in interactive and making the score array more comprehensible.

@akelad
Copy link
Contributor

akelad commented Feb 11, 2019

Thanks for raising this issue, @tmbo will get back to you about it soon.

@tmbo
Copy link
Member

tmbo commented Feb 14, 2019

yes, I think that is a great idea 👍

@tmbo tmbo changed the title [FEATURE]Sort predicted actions on probability score from HTTP API Sort predicted actions on probability score from HTTP API Feb 14, 2019
@therealdeadly
Copy link
Contributor Author

Thanks @tmbo! Can I work on this and should I make a pull request before that?

@tmbo
Copy link
Member

tmbo commented Feb 15, 2019

Yes sure - let me know if you need any help.

@therealdeadly
Copy link
Contributor Author

Alright, on it. Thanks, will let you know

@tmbo tmbo transferred this issue from RasaHQ/rasa_core Mar 21, 2019
@akelad
Copy link
Contributor

akelad commented Mar 21, 2019

@therealdeadly any luck?

@akelad akelad added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR status:more-details-needed Waiting for the user to provide more details / stacktraces / answer a question labels Mar 21, 2019
@therealdeadly
Copy link
Contributor Author

therealdeadly commented Mar 21, 2019

@akelad yes, done the work on pull request 1733 and merged with the master successfully.
New to this I thought the issue would auto-close after the merge, do I have to close it?

@no-response no-response bot removed the status:more-details-needed Waiting for the user to provide more details / stacktraces / answer a question label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

3 participants