This repository has been archived by the owner on Aug 22, 2019. It is now read-only.
WIP: sort the scores array in server.py #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tmbo
reviewed
Feb 19, 2019
| @@ -407,6 +407,9 @@ def predict(sender_id): | |||
| try: | |||
| # Fetches the appropriate bot response in a json format | |||
| responses = agent.predict_next(sender_id) | |||
| responses['scores'] = sorted(responses['scores'], | |||
There was a problem hiding this comment.
would you mind adding a test for this as well? (also would be great if you can update the api documentation as well as the CHANGELOG.rst)
There was a problem hiding this comment.
have added a test and updated the api documentation and CHANGELOG.rst
There was a problem hiding this comment.
@tmbo hey, can you please review the additions?
…ldeadly/rasa_core into sort-score-array-http-api
|
Code Climate has analyzed commit e40a41a and detected 0 issues on this pull request. View more on Code Climate. |
tmbo
approved these changes
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1707
Proposed changes:
scorearray returned from HTTP API endpoint :-/conversations/{sender_id}/predicttraining.interactive._request_action_from_user()Status (please check what you already did):
@tmbo I have added-deleted the sort from the aforementioned places, what do you think? Also, I am confused about writing new tests for these changes, the tests already in test_server.py should suffice right? or am I missing something?