Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message_id not passed in _rasa_http_parse in RasaNLUHttpInterpreter #3819

Closed
EdouM opened this issue Jun 18, 2019 · 1 comment · Fixed by #3822
Closed

Message_id not passed in _rasa_http_parse in RasaNLUHttpInterpreter #3819

EdouM opened this issue Jun 18, 2019 · 1 comment · Fixed by #3822
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@EdouM
Copy link
Contributor

EdouM commented Jun 18, 2019

Description of Problem:
message_id is not passed in the _rasa_http_parse method of the RasaNLUHttpInterpreter. It used to be passed in rasa_core but isn't anymore.

Overview of the Solution:
Simply pass the message_id from the parse method to _rasa_http_parse

Examples (if relevant):

Blockers (if relevant):

Definition of Done:

@EdouM EdouM added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Jun 18, 2019
@akelad
Copy link
Contributor

akelad commented Jun 19, 2019

i think i'd classify this as a bug for future reference 😉but awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants