-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 3819 - pass message_id to _rasa_http_parse #3822
Conversation
Thanks for submitting this PR, we'll give it a review as soon as possible |
@EdouM Implementation looks good. Just a quick question: Does it also make sense to add it the |
@tabergma indeed it makes sense to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far, but you need to add two more things:
First, please update the API specs: https://github.com/RasaHQ/rasa/blob/master/docs/_static/spec/rasa.yml#L530
Second, you need to pass on the message_id
here: https://github.com/RasaHQ/rasa/blob/master/rasa/core/interpreter.py#L258
@tabergma thanks for the suggestions, I just reviewed and pushed them. Sorry for the back and forth I should have realized this on my own but I appreciate the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks a lot for adding the remaining things 🚀 Will merge once the tests pass.
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)