Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added description of config params for tf embed classifier #1012

Merged
merged 6 commits into from Apr 18, 2018

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Apr 18, 2018

Proposed changes:

  • added description of config params for tf embed classifier

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@Ghostvv Ghostvv requested a review from amn41 April 18, 2018 13:06
@Ghostvv Ghostvv assigned tmbo and unassigned tmbo Apr 18, 2018
@Ghostvv Ghostvv requested a review from tmbo April 18, 2018 13:06
@@ -121,6 +127,10 @@ To use the components and configure them separately:
pipeline:
- name: "intent_featurizer_count_vectors"
- name: "intent_classifier_tensorflow_embedding"
intent_tokenization_flag: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs more indentation (should start at the same level as name)

@@ -121,6 +127,10 @@ To use the components and configure them separately:
pipeline:
- name: "intent_featurizer_count_vectors"
- name: "intent_classifier_tensorflow_embedding"
intent_tokenization_flag: true
intent_split_symbol: "_"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@tmbo tmbo merged commit 6797f04 into master Apr 18, 2018
@tmbo tmbo deleted the update_docs_embed branch April 18, 2018 16:20
taytzehao pushed a commit to taytzehao/rasa that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants