Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting lookup elements on bases of length in descending order #10663

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

azizullah2017
Copy link

Sorting lookup elements on bases of length in descending order, so the larger value of lookup should be matched first. The generator matches the first value and return.

Unsorted lookup

lookup:

  • one
  • twenty
  • twenty one

if input is "twenty one". it matched with "one" and "twenty"

After storing in descending order

  • twenty one
  • one
  • twenty

now if if input is "twenty one", it matched with "twenty one"

@azizullah2017 azizullah2017 requested a review from a team as a code owner January 11, 2022 10:37
@azizullah2017 azizullah2017 requested review from usc-m and removed request for a team January 11, 2022 10:37
@CLAassistant
Copy link

CLAassistant commented Jan 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ indam23
❌ azizullah2017
You have signed the CLA already but the status is still pending? Let us recheck it.

@stale
Copy link

stale bot commented Apr 16, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@m-vdb m-vdb removed the request for review from usc-m May 20, 2022 07:32
@stale stale bot removed the stale label May 20, 2022
Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @azizullah2017, this PR is quite old, if you do still want to merge it, could you add or expand a unit test to check that this fixes the behavior you mentioned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants