ENG-424: initial port of moodbot to flows / command pattern #12683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
approved these changes
Jul 20, 2023
| - are you a human? | ||
| - am I talking to a bot? | ||
| - am I talking to a human? | ||
| - intent: affirm |
There was a problem hiding this comment.
I can double check why we need them
m-vdb
changed the title
m-vdb
previously requested changes
Jul 24, 2023
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
tmbo
reviewed
Jul 25, 2023
| import pkg_resources | ||
|
|
||
| if is_dm2: | ||
| return pkg_resources.resource_filename(__name__, "initial_project_dm2") |
There was a problem hiding this comment.
resource needs to be added to pyproject.toml
There was a problem hiding this comment.
thanks for calling that out. Where though? I don't see anytihng like that for initial_project
There was a problem hiding this comment.
should be part of this line, but it is very intersting that the original one isn't
Line 21 in b5af522
it looks like, by default already anything in the module tree is added in the sdist case python-poetry/poetry#2015 (comment)
m-vdb
reviewed
Jul 25, 2023
Co-authored-by: Maxime Vdb <m.verger@rasa.com>
|
🚀 A preview of the docs have been deployed at the following URL: https://12683--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)