Duckling HTTP: uses Message time for parsing and allows to set timezone #1280
Conversation
Uses the time parameter of the Message object to give to Duckling what is the reference time. Allows also to overidde the default timezone set by Duckling (UTC -7) Closes RasaHQ#1279
|
|
|
This is looking good 👍 do you mind signing our contributor agreement? |
|
One thing, travis is failing because there are some pep8 issues with indentation, do you mind taking a look at https://travis-ci.com/RasaHQ/rasa_nlu/jobs/137686935#L1136 and change the lines accordingly? |
|
Thank you for your reviews. I've fixed the style errors hopefully. I just need to check something before signing the CLA (but it should be fine). |
|
I'd like to cut a new release in the next couple of hours. do you think you can sign it by then? otherwise we need to delay this. |
|
I just signed the CLA. Thank you for making this amazing library! |
|
Thank you for making it even better 😃 |
|
Is this added to rasa yet? I don't see it in code. |
|
it should be part of the more recent releases, yes |
Proposed changes:
Uses the time parameter of the Message object to give to Duckling what
is the reference time.
Allows also to override the default timezone set by Duckling (UTC -7)
Status (please check what you already did):
Bug: #1279