New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entity synonym fuzzy match #1629
Conversation
Thanks for submitting this PR, we'll give it a review as soon as possible |
Linking this to the original issue: #1626 |
We can not depend on |
@odannyc Any chance you could get this working with a library under an |
Before I dive too deep into implementing another library, I found this which has the MIT license. Is that fine? |
I have updated this PR to use a package that doesn't have the GPL license. Thanks! |
Still waiting on a response for this. Thanks! |
@odannyc we appreciate your hard work, but this requires some further discussion from our side. We'll get back to you once we've discussed it and ran some experiments ourselves. |
Code Climate has analyzed commit 9982fd7 and detected 0 issues on this pull request. View more on Code Climate. |
Any news? |
not yet sorry, we haven't had time to properly look into it yet |
What we still need to validate: earlier tests showed that fuzzy matching is quite slow. To avoid introducing a component that can't be used in production, we need to validate whether we can really on the chosen matching library to deliver good performance. |
I'll close this for now as it is quite outdated. But happy to reopen if @Ghostvv thinks this makes sense from a entity matching accuricy standpoint. |
Proposed changes:
ner_synonyms
Status (please check what you already did):