Increase scikit-learn version #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
requested changes
Jan 22, 2019
| @@ -178,7 +178,7 @@ def process(self, message, **kwargs): | |||
| else: | |||
| X = message.get("text_features").reshape(1, -1) | |||
| intent_ids, probabilities = self.predict(X) | |||
| intents = self.transform_labels_num2str(intent_ids) | |||
| intents = self.transform_labels_num2str(intent_ids.T) | |||
There was a problem hiding this comment.
is that correct or should it be np.ravel(intent_ids)?
Also, after this change, what happens if we run with 0.19, does it still work?
There was a problem hiding this comment.
I've included the change, but we flatten this vector in the following line so it's not an issue
Just ran the script with 0.19, it still passes
|
Code Climate has analyzed commit 3338ee2 and detected 0 issues on this pull request. View more on Code Climate. |
tmbo
approved these changes
Jan 22, 2019
tmbo
pushed a commit
that referenced
this pull request
Mar 21, 2019
Flag config parameters passed to agent.train(), remove config params from training params
taytzehao
pushed a commit
to taytzehao/rasa
that referenced
this pull request
Jul 14, 2023
…aHQ#1635) Bumps [github.com/moby/buildkit](https://github.com/moby/buildkit) from 0.11.2 to 0.11.3. - [Release notes](https://github.com/moby/buildkit/releases) - [Commits](moby/buildkit@v0.11.2...v0.11.3) --- updated-dependencies: - dependency-name: github.com/moby/buildkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-learn==0.20.2has a niceoutput_dictfeature we can use in our evaluate script, but it was causing errors with our classifierProposed changes:
intent_idsvectorscikit-learn==0.20.2Status (please check what you already did):