detect all regex in sentence #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Climate has analyzed commit 9ec7b4b and detected 0 issues on this pull request. View more on Code Climate. |
MetcalfeTom
suggested changes
Mar 4, 2019
There was a problem hiding this comment.
Good work, please add a note in CHANGELOG.rst that you fixed this bug
Other than that, just wanted to re-name a variable so it's a bit clearer what it is supposed to be
Also we can now remove the matches variable entirely.
Implement the above changes and re-tag me for review
Co-Authored-By: paulaWesselmann <38981219+paulaWesselmann@users.noreply.github.com>
merge this to update .
tmbo
requested changes
Mar 6, 2019
|
ready for another review? |
|
@tmbo yes please! |
|
@paulaWesselmann @tmbo I think you should make it optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):