Ticket lock #3877
Closed
Ticket lock #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
reviewed
Jun 26, 2019
rasa/core/lock_store.py
Outdated
| lock_timeout: float = 0.5, | ||
| retry_count: int = 20, | ||
| ) -> None: | ||
| from aioredlock import Aioredlock |
There was a problem hiding this comment.
I don't think we need the distributed lock as we expect only one redis instance, at least for now. because of that I'd rather use the redis library we are already using and try to get a prototype of the ticket lock running instead of a distributed lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)