Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-add _guess_format(...) to not brake compatibility with Rasa X #3968

Merged
merged 4 commits into from Jul 9, 2019
Merged

re-add _guess_format(...) to not brake compatibility with Rasa X #3968

merged 4 commits into from Jul 9, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 9, 2019 •
edited

Proposed changes:

  • re-add _guess_format to not break compatibility with Rasa X`

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@wochinge
Copy link
Contributor Author

wochinge commented Jul 9, 2019

@erohmensing What do you think? Think we could save ourselves a couple of github issues with that.

erohmensing
erohmensing approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please no breaking changes in compatability on a patch release 👍 good idea

rasa/nlu/training_data/loading.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/loading.py Outdated Show resolved Hide resolved
wochinge and others added 2 commits July 9, 2019 18:36
@wochinge @erohmensing
Update rasa/nlu/training_data/loading.py
ee3a859 
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
@wochinge @erohmensing
Update rasa/nlu/training_data/loading.py
eb258ca 
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
@wochinge wochinge merged commit a71c469 into master Jul 9, 2019
@wochinge wochinge deleted the _guess-format branch July 9, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees

@erohmensing erohmensing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wochinge @erohmensing