Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return after starting server in cli/run.py #4023

Merged
merged 1 commit into from Jul 16, 2019
Merged

Conversation

federicotdn
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@federicotdn federicotdn merged commit f20651b into master Jul 16, 2019
@federicotdn federicotdn deleted the fix-cli-run branch July 16, 2019 09:10
@kshitiz1318
Copy link

Hi,

Inspite of putting return statement after every rasa.run command, I am getting the error 'No model found'.
Is it a change in the new version because in the older version, there was no such problem.

@federicotdn
Copy link
Contributor Author

@kshitiz1318 The commit I pushed to master should have solved the issue, it will be part of the next release. What's the exact command you're running to get the error?

@kshitiz1318
Copy link

Now I used your rasa/cli/run.py file, there is no error. But when I send any message in the rasa shell it exits the shell without responding anything.
Command which I was and I am using is either rasa shell or rasa run. Earlier there was error, now there is no error but it is not running

@federicotdn
Copy link
Contributor Author

There's a chance that changing only the run.py file won't solve the problem (if you're using the latest stable release), because there have been changes to other files as well. Could you try cloning the repo and trying again with the latest commit?

@kshitiz1318
Copy link

Sure will try that and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No model found" error message when model was loaded correctly
3 participants