Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull runtime config from endpoint #4032

Merged
merged 27 commits into from Jul 24, 2019
Merged

Pull runtime config from endpoint #4032

merged 27 commits into from Jul 24, 2019

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented Jul 17, 2019

Proposed changes:

  • adds --config-endpoint arg to rasa x

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@ricwo ricwo requested review from wochinge and removed request for wochinge July 17, 2019 15:09
wochinge
wochinge suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool addition to rasa 🚀
Do we need docs about this?

rasa/cli/utils.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
rasa/cli/x.py Outdated Show resolved Hide resolved
wochinge
wochinge approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🎸 Changelog update is then done when you merge ticket_lock?

rasa/cli/x.py Outdated Show resolved Hide resolved
@ricwo ricwo merged commit fd2ae15 into ticket_lock Jul 24, 2019
@ricwo ricwo deleted the config_endpoint branch July 24, 2019 05:43
@ricwo ricwo restored the config_endpoint branch July 24, 2019 05:43
@ricwo ricwo deleted the config_endpoint branch July 24, 2019 05:43
@ricwo ricwo restored the config_endpoint branch July 24, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ricwo @wochinge