-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added template for image, attachment, quick_replies, buttons #4077
Added template for image, attachment, quick_replies, buttons #4077
Conversation
Thanks for the PR, we'll give it a review as soon as possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your cool addition 🎉 Great to have such motivated community members 💯
I left a few comments :-) Could you please also update the changelog?
@RanaMostafaAbdElMohsen Just the changelog missing :-) |
|
|
@wochinge, Please check if there are any additional comments |
@RanaMostafaAbdElMohsen added two more comments :-) |
…led + modified CHANGELOG to include only image template
@wochinge , please check again. Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion regarding the changelog and there are a couple of merge conflicts with master. Tests are looking great 🎸
Done @wochinge. Can you please advise why the coverage decreased, although I covered all the test cases ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, there were so many changes in this module in the mean while 🙈
added another comment. Sorry, for the hassle!
Could you also remove the unused imports please?
I will fill slots for buttons, attachments, quick_replies as well as images and will update CHANGELOG.rst @wochinge |
@RanaMostafaAbdElMohsen Are you sure it's actually a use case to have that in buttons, attachments, and quick_replies? We can also do images first and then see whether others actually need interpolation for the others. |
@wochinge |
@RanaMostafaAbdElMohsen Awesome, then let's update the changelog and merge this :-) |
Co-Authored-By: Tobias Wochinger <mail@tobias-wochinger.de>
Done @wochinge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks for your contribution 🥇
Fixes for #3763:
Status (please check what you already did):
black
(please check Readme for instructions)