Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meta descriptions (Rasa) #4084

Merged
merged 11 commits into from Aug 1, 2019
Merged

Update meta descriptions (Rasa) #4084

merged 11 commits into from Aug 1, 2019

Conversation

msamogh
Copy link
Contributor

@msamogh msamogh commented Jul 23, 2019 •
edited

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@msamogh msamogh changed the title Update meta descriptions Update meta descriptions (Rasa) Jul 25, 2019
@msamogh msamogh requested review from erohmensing and MetcalfeTom and removed request for erohmensing July 26, 2019 07:35
MetcalfeTom
MetcalfeTom approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@MetcalfeTom MetcalfeTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you help improving the open source chatbot framework Rasa. Google front page here we come!

Can you also fix the formatting in multi-skill-assistants.rst (two dots before :desc:)

docs/dialogue-elements/dialogue-elements.rst Show resolved Hide resolved
docs/nlu/components.rst Outdated Show resolved Hide resolved
docs/user-guide/cloud-storage.rst Outdated Show resolved Hide resolved
docs/user-guide/command-line-interface.rst Outdated Show resolved Hide resolved
docs/api/action-server.rst Outdated Show resolved Hide resolved
@msamogh msamogh merged commit 5d9fe71 into master Aug 1, 2019
@msamogh msamogh deleted the meta-desc branch August 1, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing left review comments

@MetcalfeTom MetcalfeTom MetcalfeTom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msamogh @erohmensing @MetcalfeTom