fix 'rasa test core' #4094
Merged
fix 'rasa test core' #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is failing as the models are not properly trained right now. I guess something went wrong in one of the merge commits. Need to find the bug. Will let you know, once it is fixed. |
|
@arthurTemporim @wochinge Issue is solved. Ready for review. |
wochinge
reviewed
Jul 25, 2019
wochinge
approved these changes
Jul 25, 2019
wochinge
reviewed
Jul 25, 2019
wochinge
reviewed
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
--evaluate-models-in-dirto test commandrasa test coreto be able to compare models that were trained viarasa train core -c <config-1> <config-2>rasa test corecan handle compressed model fileslist_files,list_subdirectories,list_directory,create_dir) fromrasa.nlu.utilstorasa.utils.iocloses #4016
Status (please check what you already did):
black(please check Readme for instructions)