Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External triggers #4095

Merged
merged 23 commits into from Jul 29, 2019
Merged

External triggers #4095

merged 23 commits into from Jul 29, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jul 24, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@wochinge
Copy link
Contributor Author

@erohmensing Should we add docs for it and if yes, where? I would add docs and probably somewhere to https://rasa.com/docs/rasa/user-guide/messaging-and-voice-channels/ ?

@erohmensing
Copy link
Contributor

erohmensing commented Jul 24, 2019

Definitely would add docs about this. Yeah i would just add them that page you linked -- I think we should add more high-level explanation of what input and output channels do on that page anyway.

However we should also have a header under Actions with a quick description and a link to the info in the channel docs since i think people would be likely to look for the info there

@wochinge
Copy link
Contributor Author

@erohmensing Added some docs, could you check please?

@wochinge wochinge marked this pull request as ready for review July 24, 2019 16:03
@wochinge wochinge requested a review from tabergma July 24, 2019 16:05
docs/_static/spec/rasa.yml Show resolved Hide resolved
docs/_static/spec/rasa.yml Outdated Show resolved Hide resolved
rasa/core/channels/channel.py Outdated Show resolved Hide resolved
rasa/server.py Show resolved Hide resolved
rasa/server.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@wochinge
Copy link
Contributor Author

@erohmensing Do you have any more comments on the docs?

@amn41
Copy link
Contributor

amn41 commented Jul 25, 2019

@wochinge very nice - looks like a clean solution. So does a user implement a single custom action for this proactive outreach? Can this be used for simple utteractions? Not super clear from the docs

@wochinge
Copy link
Contributor Author

wochinge commented Jul 25, 2019

So does a user implement a single custom action for this proactive outreach? Can this be used for simple utteractions? Not super clear from the docs

They can trigger any action, so utter_* or some custom action action_*. If the response is not static, it's most probably a custom action. I added a bit more in the docs 👍

@wochinge
Copy link
Contributor Author

@MetcalfeTom Do you have some input on the docs? (I believe Ella is busy testing 😄 )

@erohmensing
Copy link
Contributor

@wochinge I edited a few small wordings and added some explanation, but overall was great 👍

@wochinge wochinge merged commit 9dcfc76 into master Jul 29, 2019
@wochinge wochinge deleted the external-triggers branch July 29, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for external triggers / asynchronous actions
4 participants