Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new SQL event broker and use it for local Rasa X #4097

Merged
merged 10 commits into from Jul 30, 2019
Merged

Add new SQL event broker and use it for local Rasa X #4097

merged 10 commits into from Jul 30, 2019

Conversation

federicotdn
Copy link
Contributor

@federicotdn federicotdn commented Jul 24, 2019 •
edited

Proposed changes:

  • Create a new event broker, SQLProducer (inherits from EventChannel).
  • Use SQLProducer when running Rasa X in local mode. Any event tracker can be used.
  • If the user wants to run Rasa X locally with a different event broker than SQLProducer, ask them if they want to change it to SQLProducer. If the answer is no, quit.
  • Make SQLEvent::_get_db_url() a public method.
  • Fixes SQLite event stream #3702.

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@federicotdn federicotdn changed the title Add new SQL event broker and use it for local Rasa X. Add new SQL event broker and use it for local Rasa X Jul 24, 2019
@federicotdn federicotdn marked this pull request as ready for review July 26, 2019 09:29
wochinge
wochinge reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely through yet. Will continue later. Looks great and very clean so far 🚀

.gitignore Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
docs/api/event-brokers.rst Outdated Show resolved Hide resolved
rasa/core/broker.py Outdated Show resolved Hide resolved
rasa/core/broker.py Outdated Show resolved Hide resolved
rasa/core/broker.py Outdated Show resolved Hide resolved
rasa/core/broker.py Outdated Show resolved Hide resolved
rasa/core/tracker_store.py Show resolved Hide resolved
wochinge
wochinge approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality looks great! Can't wait to put it in production.

rasa/core/broker.py Show resolved Hide resolved
rasa/core/broker.py Outdated Show resolved Hide resolved
rasa/core/broker.py Outdated Show resolved Hide resolved
@federicotdn
Copy link
Contributor Author

@wochinge Thanks! Will fix the stuff you commented on.

@federicotdn federicotdn merged commit 4674f15 into master Jul 30, 2019
@federicotdn federicotdn deleted the sql-event-broker branch July 30, 2019 11:11
@wochinge wochinge mentioned this pull request Jul 31, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQLite event stream
2 participants
@federicotdn @wochinge