New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove setWebhook since it is already set before #4171
Conversation
Hehe, did you break this from async actions? 😁If so have you checked the other channels to make sure this isn't happening anywhere else? |
yes :-D
The telegram channel is the only one where we set something extra (the webhook). So it should be fine 🎉 |
Awesome, but can we please open this against 1.2.x 😁 |
I also could have just changed it. And I have to merge it both in |
Haha ok this is true I'm sorry 😅 |
Do you know if when community members make PRs we can change where they're trying to merge to? Or do we have to ask them to? |
we can definitely ask them to merge to 1.2.x. |
Yeah just also was wondering if there is an easier way that we can get them to do it without having to ask every time. What do you mean cherry pick, can't you just merge master <--- 1.2.x after we merge it on 1.2.x? |
I mean |
I thought you always merged changes to the patch branch to master as you do them |
not according to the figure you shared in the Slack channel (would be also too much hassle) |
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)