Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setWebhook since it is already set before #4171

Closed
wants to merge 1 commit into from

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Aug 5, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@erohmensing
Copy link
Contributor

Hehe, did you break this from async actions? 😁If so have you checked the other channels to make sure this isn't happening anywhere else?

@wochinge
Copy link
Contributor Author

wochinge commented Aug 5, 2019

Hehe, did you break this from async actions?

yes :-D

If so have you checked the other channels to make sure this isn't happening anywhere else?

The telegram channel is the only one where we set something extra (the webhook). So it should be fine 🎉

@erohmensing
Copy link
Contributor

erohmensing commented Aug 5, 2019

Awesome, but can we please open this against 1.2.x 😁

@erohmensing erohmensing closed this Aug 5, 2019
@wochinge
Copy link
Contributor Author

wochinge commented Aug 5, 2019

I also could have just changed it. And I have to merge it both in master and 1.2.x

@erohmensing
Copy link
Contributor

Haha ok this is true I'm sorry 😅

@erohmensing
Copy link
Contributor

Do you know if when community members make PRs we can change where they're trying to merge to? Or do we have to ask them to?

@wochinge
Copy link
Contributor Author

wochinge commented Aug 5, 2019

we can definitely ask them to merge to 1.2.x.
Should I also cherry-pick this on master?

@erohmensing
Copy link
Contributor

Yeah just also was wondering if there is an easier way that we can get them to do it without having to ask every time. What do you mean cherry pick, can't you just merge master <--- 1.2.x after we merge it on 1.2.x?

@wochinge
Copy link
Contributor Author

wochinge commented Aug 5, 2019

I mean git cherry-pick <commit hash>. I think the merge to master is only when we create 1.3, but I'd like to have it on master asap for the community member.

@erohmensing
Copy link
Contributor

I thought you always merged changes to the patch branch to master as you do them

@wochinge
Copy link
Contributor Author

wochinge commented Aug 5, 2019

not according to the figure you shared in the Slack channel (would be also too much hassle)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegram channel broken in latest update
2 participants