Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.2.2 merge #4192

Merged
merged 7 commits into from Aug 7, 2019
Merged

1.2.2 merge #4192

merged 7 commits into from Aug 7, 2019

Conversation

msamogh
Copy link
Contributor

@msamogh msamogh commented Aug 7, 2019 •
edited

Proposed changes:

  • Merge 1.2.2

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

wochinge
wochinge approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@MetcalfeTom MetcalfeTom merged commit 660b2db into master Aug 7, 2019
@MetcalfeTom MetcalfeTom deleted the 1.2.2-merge branch August 7, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

@MetcalfeTom MetcalfeTom MetcalfeTom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msamogh @wochinge @MetcalfeTom