move multi skill docs to data importer docs #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetcalfeTom
reviewed
Aug 7, 2019
amn41
requested changes
Aug 7, 2019
docs/api/training-data-importers.rst
Outdated
| us making this feature ready for production. | ||
|
|
||
| With this importer you can build a contextual AI assistant by combining | ||
| reusable "building blocks" called skills. |
There was a problem hiding this comment.
do we really need to call them skills? do they have to have a name? We already introduce a whole bunch of terms in e.g. the dialogue elements, I'd like to avoid introducing yet another term here. Can we just call them projects?
There was a problem hiding this comment.
Should we also rename the SkillSelector or can we keep it that way?
There was a problem hiding this comment.
yeah let's change the name all the way down
There was a problem hiding this comment.
then something like MultiProjectImporter?
There was a problem hiding this comment.
renamed it and reorganized test files
Co-Authored-By: Alan Nichol <alan@rasa.com>
Co-Authored-By: Alan Nichol <alan@rasa.com>
Co-Authored-By: Thomas Metcalfe <t.metcalfe@rasa.com>
amn41
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
SkillSelectoras experimentalSkillSelectordocs to data importer docsStatus (please check what you already did):
black(please check Readme for instructions)