revamp language support page #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetcalfeTom
approved these changes
Aug 14, 2019
Co-Authored-By: Thomas Metcalfe <t.metcalfe@rasa.com>
akelad
approved these changes
Aug 15, 2019
There was a problem hiding this comment.
overall looks good - two small comments.
I'm still not 100% happy with how this info is split across 2 pages though.. the info about pretrained word embeddings is kind of on both the choosing a pipeline + language support pages, which is a bit weird. But for now I think this is ok
erohmensing
commented
Aug 15, 2019
|
Agreed about it being weird to be split across the pages. I think the choosing a pipeline page needs a full look-over since there's just so much information on it. Was trying to keep the language support page just about supported languages, not configuring them, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)