Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show warning in case default value is used instead of invalid value #4249

Merged
merged 1 commit into from Aug 14, 2019
Merged

show warning in case default value is used instead of invalid value #4249

merged 1 commit into from Aug 14, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Aug 14, 2019 •
edited

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from tabergma August 14, 2019 16:08
tabergma
tabergma approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the warning! Looks good 👍

@wochinge wochinge merged commit b18e7cb into master Aug 14, 2019
@wochinge wochinge deleted the warning-when-using-default-instead-of-invalid branch August 14, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rasa test nlu -u option doesn't handle exception correctly
2 participants
@wochinge @tabergma